Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels nit #3441

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Labels nit #3441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions web/src/components/admin/connectors/Field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ export function TextFormField({
min,
onChange,
width,
vertical,
}: {
value?: string;
name: string;
Expand All @@ -170,6 +171,7 @@ export function TextFormField({
min?: number;
onChange?: (e: React.ChangeEvent<HTMLInputElement>) => void;
width?: string;
vertical?: boolean;
}) {
let heightString = defaultHeight || "";
if (isTextArea && !heightString) {
Expand Down Expand Up @@ -209,14 +211,16 @@ export function TextFormField({

return (
<div className={`w-full ${width}`}>
<div className="flex flex-col gap-x-2 items-start">
{!removeLabel && (
<Label className={sizeClass.label} small={small}>
{label}
</Label>
)}
{optional ? <span>(optional) </span> : ""}
{tooltip && <ToolTipDetails>{tooltip}</ToolTipDetails>}
<div className={`flex ${vertical ? "flex-col" : "flex-row"} items-start`}>
<div className="flex gap-x-2 items-center">
{!removeLabel && (
<Label className={sizeClass.label} small={small}>
{label}
</Label>
)}
{optional ? <span>(optional) </span> : ""}
{tooltip && <ToolTipDetails>{tooltip}</ToolTipDetails>}
</div>
{error ? (
<ManualErrorMessage>{error}</ManualErrorMessage>
) : (
Expand Down
1 change: 1 addition & 0 deletions web/src/components/modals/EditPropertyModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ const EditPropertyModal = ({
</h2>

<TextFormField
vertical
label={propertyDetails || ""}
name="propertyValue"
placeholder="Property value"
Expand Down
Loading