Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing Onyx! #3439

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Introducing Onyx! #3439

merged 7 commits into from
Dec 13, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Dec 12, 2024 •
edited
Loading

Description

  • docs.danswer.dev -> docs.onyx.app
  • danswer.ai -> onyx.app
  • github.com/danswer-ai/danswer -> github.com/onyx-dot-app/onyx
  • Danswer -> Onyx
  • danswer -> onyx

Values which contain Danswer still

  • DanswerAI Corp references
  • cal.com links
  • Index names / configuration
  • Slack link (updated but still contains "danswer" in link

How Has This Been Tested?

[Test] = search + chat + index documents + sync doc sets

  • Upgrade -> Testing -> Downgrade -> Test -> Upgrade

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 7:39pm

@pablonyx pablonyx changed the title removal goodbye danswer Dec 12, 2024
@pablonyx pablonyx changed the title goodbye danswer Introducing Onyx! Dec 12, 2024
yuhongsun96
yuhongsun96 reviewed Dec 12, 2024
View reviewed changes
backend/ee/onyx/configs/app_configs.py Outdated
@@ -34,7 +34,7 @@


# Super Users
SUPER_USERS = json.loads(os.environ.get("SUPER_USERS", '["pablo@danswer.ai"]'))
SUPER_USERS = json.loads(os.environ.get("SUPER_USERS", '["pablo@onyx.app"]'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL this seems kinda suspect XD should probably just make it empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fair!

@yuhongsun96
Copy link
Contributor

Some things to consider (seems like you've done a lot of these already)

  • Are there things in the migrations/tables that we need to rename etc?
    • Tables with Danswer in it like danswerbot_flow
  • Anything in the celery queues or redis cache that need to be handled?
  • Anything in Vespa? (danswer_chunk)
  • Have we updated the docker container repos?
  • The company is still DanswerAI, Inc. too much unnecessary work to change the company filings, legal, cap table, etc.

On testing:

  • Can we upgrade a fairly well populated instance (test.danswer.dev)
    • With slack
    • With EE features
    • With connectors/document sets/user created assistants
    • Run some searches
    • Run some indexing
  • Try a fresh deploy and set up a lot of the functionalities, just play around with it a bit

rkuo-danswer
rkuo-danswer reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@rkuo-danswer rkuo-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only comment i have is that some of the keys in redis start with "da_" so we could in theory change those. I'm not sure the keys even need the prefix right now so maybe we just remove the prefix.

yuhongsun96
yuhongsun96 reviewed Dec 13, 2024
View reviewed changes
LICENSE Outdated
@@ -1,9 +1,9 @@
Copyright (c) 2023-present DanswerAI, Inc.
Copyright (c) 2023-present OnyxAI, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one needs to remain "DanswerAI, Inc.", "OnyxAI, Inc." does not exist

@pablonyx pablonyx enabled auto-merge December 13, 2024 19:40
@pablonyx pablonyx disabled auto-merge December 13, 2024 19:41
@pablonyx pablonyx merged commit 86f2892 into main Dec 13, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkuo-danswer rkuo-danswer rkuo-danswer left review comments

@yuhongsun96 yuhongsun96 yuhongsun96 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablonyx @yuhongsun96 @rkuo-danswer