ensure all timeout -> hook #2718
Merged
+19
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR simplifies the connector deletion process and improves user feedback in the admin interface of Danswer.
- Removed success popup and timeout after connector deletion in
/web/src/app/admin/connector/[ccPairId]/page.tsx - Added immediate redirect to indexing status page with query parameter for deletion success
- Updated
/web/src/app/admin/indexing/status/page.tsxto handle new query parameter and display success message - Moved
usePopupFromQueryhook to top-level Status component for better organization
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| router, | ||
| finishConnectorDeletion, | ||
| ]); | ||
| }, [isLoading, ccPair, error, hasLoadedOnce]); |
There was a problem hiding this comment.
logic: finishConnectorDeletion is not in the dependency array, which may cause issues with the useEffect hook
rkuo-danswer
approved these changes
Oct 7, 2024
rkuo-danswer
approved these changes
Oct 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: