Hotfix/v0.7 harden redis #2683
Merged
Hotfix/v0.7 harden redis #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request enhances Redis reliability in the Danswer project, focusing on Celery configuration and Redis connection pool improvements.
- Introduced
BlockingConnectionPoolinredis_pool.pyfor more deterministic behavior when max connections are reached - Added health checks, connection retries, and socket keepalive options in
celeryconfig.pyfor improved Redis stability - Implemented platform-specific Redis socket keepalive options in
constants.pyfor better connection persistence - Added new Redis and Celery configuration settings in
app_configs.py, includingCELERY_BROKER_POOL_LIMIT - Updated Docker Compose files to include the new
CELERY_BROKER_POOL_LIMITenvironment variable
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+214
to
+217
| if platform.system() == "Darwin": | ||
| REDIS_SOCKET_KEEPALIVE_OPTIONS[socket.TCP_KEEPALIVE] = 60 # type: ignore | ||
| else: | ||
| REDIS_SOCKET_KEEPALIVE_OPTIONS[socket.TCP_KEEPIDLE] = 60 # type: ignore |
There was a problem hiding this comment.
style: Consider adding a more specific else condition for Linux systems, as the current else block might apply to Windows as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ports some redis reliability changes to release/0.7
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: