Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump celery #2675

Merged
merged 2 commits into from
Oct 3, 2024
Merged

bump celery #2675

merged 2 commits into from
Oct 3, 2024

Conversation

rkuo-danswer
Copy link
Contributor

Description

updates celery to 5.5.0b4 for redis reconnection fixes.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 5:26pm

@rkuo-danswer rkuo-danswer marked this pull request as ready for review October 3, 2024 17:59
@rkuo-danswer rkuo-danswer merged commit 7c7f5b3 into release/v0.7 Oct 3, 2024
6 checks passed
@rkuo-danswer rkuo-danswer deleted the hotfix/v0.7-bump-celery branch October 3, 2024 17:59
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request updates the Celery library to version 5.5.0b4 in the backend requirements, aiming to address Redis reconnection issues.

  • Updated celery==5.5.0b4 in backend/requirements/default.txt to fix Redis reconnection problems
  • Potential impact on celery_app.py and other Celery-related functionalities should be carefully reviewed
  • Beta version upgrade may introduce stability or compatibility issues, requiring thorough testing
  • Ensure Redis connection handling and Celery task processing remain stable after the update
  • Consider monitoring performance and reliability closely after deployment

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant