Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update merge queue logic #2554

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Update merge queue logic #2554

merged 2 commits into from
Sep 24, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Sep 24, 2024

Description

  • github.head_ref: Works for pull_request events and provides the source branch name of the PR.
  • github.event.workflow_run.head_branch: Works for workflows triggered by merge_group events. Branch which initiated the run
  • run_id: fallback

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 6:28pm

@pablonyx pablonyx marked this pull request as ready for review September 24, 2024 18:23
@rkuo-danswer rkuo-danswer added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit c59d1ff Sep 24, 2024
7 checks passed
@rkuo-danswer rkuo-danswer deleted the merge_integration_fix branch September 24, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants