Remove deprecated constructor

resolves spring-cloud#6021 Signed-off-by: Glenn Renfro <[email protected]> Add deprecation removal note to whats-new doc Signed-off-by: Glenn Renfro <[email protected]>
onobc · Nov 6, 2024 · 0b7db9c · 0b7db9c
1 parent 7b0a898
commit 0b7db9c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 58 deletions.
diff --git a/...a/org/springframework/cloud/dataflow/server/service/impl/DefaultTaskExecutionService.java b/...a/org/springframework/cloud/dataflow/server/service/impl/DefaultTaskExecutionService.java
@@ -166,64 +166,6 @@ public class DefaultTaskExecutionService implements TaskExecutionService {
 		"or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', " +
 		"or 'abc-123')";
 
-	/**
-	 * Initializes the {@link DefaultTaskExecutionService}.
-	 *
-	 * @param propertyResolver                          the spring application context
-	 * @param launcherRepository                        the repository of task launcher used to launch task apps.
-	 * @param auditRecordService                        the audit record service
-	 * @param taskRepository                 			the repository to use for accessing and updating task executions
-	 * @param taskExecutionInfoService                  the service used to setup a task execution
-	 * @param taskDeploymentRepository                  the repository to track task deployment
-	 * @param taskDefinitionRepository                  the repository to query the task definition
-	 * @param taskExecutionRepositoryService            the service used to create the task execution
-	 * @param taskAppDeploymentRequestCreator           the task app deployment request creator
-	 * @param taskExplorer                              the task explorer
-	 * @param dataflowTaskExecutionDao			        the dataflow task execution dao
-	 * @param dataflowTaskExecutionMetadataDao          repository used to manipulate task manifests
-	 * @param dataflowTaskExecutionQueryDao             repository to query aggregate TaskExecution data
-	 * @param oauth2TokenUtilsService                   the oauth2 token server
-	 * @param taskSaveService                           the task save service
-	 * @param taskConfigurationProperties               task configuration properties.
-	 */
-	@Deprecated
-	public DefaultTaskExecutionService(
-		PropertyResolver propertyResolver,
-		LauncherRepository launcherRepository,
-		AuditRecordService auditRecordService,
-		TaskRepository taskRepository,
-		TaskExecutionInfoService taskExecutionInfoService,
-		TaskDeploymentRepository taskDeploymentRepository,
-		TaskDefinitionRepository taskDefinitionRepository,
-		TaskExecutionCreationService taskExecutionRepositoryService,
-		TaskAppDeploymentRequestCreator taskAppDeploymentRequestCreator,
-		DataflowTaskExplorer taskExplorer,
-		DataflowTaskExecutionDao dataflowTaskExecutionDao,
-		DataflowTaskExecutionMetadataDao dataflowTaskExecutionMetadataDao,
-		DataflowTaskExecutionQueryDao dataflowTaskExecutionQueryDao,
-		OAuth2TokenUtilsService oauth2TokenUtilsService,
-		TaskSaveService taskSaveService,
-		TaskConfigurationProperties taskConfigurationProperties
-	) {
-		this(propertyResolver,
-			launcherRepository,
-			auditRecordService,
-			taskRepository,
-			taskExecutionInfoService,
-			taskDeploymentRepository,
-			taskDefinitionRepository,
-			taskExecutionRepositoryService,
-			taskAppDeploymentRequestCreator,
-			taskExplorer,
-			dataflowTaskExecutionDao,
-			dataflowTaskExecutionMetadataDao,
-			dataflowTaskExecutionQueryDao,
-			oauth2TokenUtilsService,
-			taskSaveService,
-			taskConfigurationProperties,
-			null);
-	}
-
 	/**
 	 * Initializes the {@link DefaultTaskExecutionService}.
 	 *

diff --git a/whats-new.adoc b/whats-new.adoc
@@ -39,6 +39,7 @@ VersionInfoProperties versionInfoProperties, SecurityStateBean securityStateBean
 * `findByTaskNameContainsAndDslTextContains` deprecated method has been removed from `TaskDefinitionRepository`.
 * `DockerComposeRule.waitingForService(String serviceName, HealthCheck<Container> healthCheck)` has been replaced by `DockerComposeRule.waitingForService(String serviceName, HealthCheck<Container> healthCheck, ReadableDuration timeout)`.
 * The deprecated `rollback(String releaseName, int releaseVersion)` method in SkipperClient has been removed.  Use  `rollback(RollbackRequest rollbackRequest).
+* Removed the `DefaultTaskExecutionService` constructor that does not take the `composedTaskRunnerConfigurationProperties` parameter.  Use the constructor that offers the `composedTaskRunnerConfigurationProperties` parameter.
 
 === Breaking Changes
 Announce deprecated changes here