Add of Online Hierarchical Clustering

[kchardon]

No description provided.

[MaxHalford]

Hey there! I hope it's ok for me to answer only by now.

Am I correct in assuming the algorithm stores all the data points it sees in memory (i.e. the X attribute)?

[kchardon]

Hey there! I hope it's ok for me to answer only by now.

Am I correct in assuming the algorithm stores all the data points it sees in memory (i.e. the X attribute)?

Hello, sorry for replying that late.
I use the window_size attribute and when there are more data than allowed, it deletes the oldest data point.
If window_size < 1, then it stores all the data points

[MaxHalford]

If window_size < 1, then it stores all the data points

Ok I see, fair. But I don't think we'll ever want that behavior. Could you remove it?

[kchardon]

If window_size < 1, then it stores all the data points

Ok I see, fair. But I don't think we'll ever want that behavior. Could you remove it?

Yes I can. So I add an error if the value of window_size is not an integer > 0 ?

[MaxHalford]

Nope, no need to check for an error. An exception will raise itself at some point. In general, we don't do input validation. Instead, we document well.

[kchardon]

Okay ! I will delete it

[hoanganhngo610]

Hi @kchardon! I am Hoang-Anh, the maintainer of the clustering module of River. For now, I think that it would be best if I can take over the review of this PR and proceed with it to get it merged to River as soon as possible, since from my first glance, the PR has been of really high quality.
If you wouldn't mind, first, I will start by refactoring the code and make changes to make it align with the rest from River. After all necessary changes are in place, I will get @MaxHalford to have a final look and give the green light.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[kchardon]

Hello, sorry to come back to this PR so late.
I've changed the code to not rely on numpy and fixed the issues during the checks.
Let me know if anything else can be improved!