Galician flag added #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoek
reviewed
Nov 5, 2024
| @@ -310,3 +310,4 @@ | |||
| .f16 ._Munster{background-position:0 -4912px;} | |||
| .f16 ._Connacht{background-position:0 -4928px;} | |||
| .f16 ._Ireland_Provinces{background-position:0 -4944px;} | |||
| .f16 ._{background-position:0 -4960px;} | |||
There was a problem hiding this comment.
These css classes needs to be named _Galicia, I would expect something like
.f16 ._Galicia{background-position:0 -4960px;}
in this instance
There was a problem hiding this comment.
If the problem was originated when doing:
./add_flag Galicia _Galicia bumped_galicia.png
it is solved. Thanks
There was a problem hiding this comment.
Hmm, now I'm seeing a duplicate entry, can you remove the _ one? From the flag file too, now there are two Galician flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to add the galician flag to the server. Thanks