Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a toggle to turn on display of seek graph #2871

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Provide a toggle to turn on display of seek graph #2871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d3b9ef
Provide a toggle to turn on display of seek graph
GreenAsJade Nov 24, 2024
5cc7f1d
Default to off (was on just for testing!)
GreenAsJade Nov 24, 2024
909add7
Save their preference about showing the seek graph
GreenAsJade Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/preferences.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ export const defaults = {
"show-move-numbers": true,
"show-offline-friends": true,
"show-ratings-in-rating-grid": false,
"show-seek-graph": false,

"show-tournament-indicator": true, // implicitly on desktop
"show-tournament-indicator-on-mobile": false,
Expand Down
52 changes: 51 additions & 1 deletion src/views/Play/CustomGames.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,62 @@
align-items: stretch;
justify-content: center;
box-sizing: border-box;

.header-container {
width: 100%;
display: flex;
justify-content: space-between;
align-items: center;
padding: 0.5em 0;
border-bottom: 1px solid #ccc;

.header-title {
margin: 0;
font-size: 1.5em;
flex-grow: 1;
}

.toggle-container {
cursor: pointer;
display: flex;
align-items: center;
gap: 0.2em;

.toggle-indicator{
background: none;
border: none;
font-size: 0.8em;
padding: 0;
line-height: 1;
}

.toggle-label {
font-size: 0.9em;
color: #666;
}
}
}


// This shenanigans is needed to ensure that the canvas of the seek graph
// remains rendered, so we don't loose the reference we have to it.
.seek-graph-container.hidden {
clip-path: inset(0 100% 100% 0); /* Clip the entire element */
position: absolute; /* Remove it from the layout */
}

.seek-graph-container.visible {
.seek-graph-container.visible {
clip-path: none; /* Restore visibility */
position: static; /* Return to normal layout */
}
}

.Modal {
border: none;
box-shadow: none;
}

.ChallengeModal {
width: 100%;
max-height: unset;
Expand Down
34 changes: 32 additions & 2 deletions src/views/Play/CustomGames.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import * as preferences from "@/lib/preferences";
import * as player_cache from "@/lib/player_cache";
import * as rengo_utils from "@/lib/rengo_utils";

import { usePreference } from "@/lib/preferences";
import { del } from "@/lib/requests";
import { alert } from "@/lib/swal_config";
import { OgsResizeDetector } from "@/components/OgsResizeDetector";
Expand Down Expand Up @@ -74,6 +75,12 @@ export function CustomGames(): JSX.Element {
const canvas: HTMLCanvasElement = React.useMemo(() => allocateCanvasOrError(), []);
const seekgraph = React.useRef<SeekGraph>();

const [seekGraphVisible, setSeekGraphVisible] = usePreference("show-seek-graph");

const toggleSeekGraph = () => {
setSeekGraphVisible(!seekGraphVisible);
};

// Used to not change the challenge list while they are trying to point the mouse at it
const [freeze_challenge_list, setFreezeChallengeList] = React.useState<boolean>(false);

Expand Down Expand Up @@ -463,9 +470,32 @@ export function CustomGames(): JSX.Element {
)}
</Card>
<div className="row">
<h2>{pgettext("Games available to accept", "Available Games")}</h2>
<div className="row header-container">
<h2 className="header-title">
{pgettext("Games available to accept", "Available Games")}
</h2>
<div className="toggle-container" onClick={toggleSeekGraph}>
<div className="toggle-indicator">{seekGraphVisible ? "▼" : "▶"}</div>
<span className="toggle-label">
{seekGraphVisible
? pgettext(
"label for button to hide the graph of available challenges vs rank",
"Hide plot",
)
: pgettext(
"label for button to show the graph of available challenges vs rank",
"Show plot",
)}
</span>
</div>
</div>

<div ref={ref_container} className="seek-graph-container">
<div
ref={ref_container}
className={`seek-graph-container ${
seekGraphVisible ? "visible" : "hidden"
}`}
>
<OgsResizeDetector onResize={onResize} targetRef={ref_container} />
<PersistentElement elt={canvas} />
</div>
Expand Down
Loading