Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard GoThemePicker against trying to persist null elements. #2817

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Guard GoThemePicker against trying to persist null elements. #2817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/components/GobanThemePicker/GobanThemePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export function GobanBoardThemePicker(props: GobanThemePickerProperties): JSX.El
style={theme.styles}
onClick={selectTheme.current[theme.theme_name]}
>
<PersistentElement elt={canvases.current[idx]} />
{canvases.current[idx] && <PersistentElement elt={canvases.current[idx]} />}
</div>
))}
</div>
Expand Down Expand Up @@ -173,7 +173,7 @@ export function GobanCustomBoardPicker(props: GobanThemePickerProperties): JSX.E
style={theme.styles}
onClick={() => setBoard("Custom")}
>
<PersistentElement elt={sample_canvas.current} />
{sample_canvas && <PersistentElement elt={sample_canvas.current} />}
</div>
</div>

Expand Down Expand Up @@ -353,7 +353,9 @@ export function GobanWhiteThemePicker(props: GobanThemePickerProperties): JSX.El
}}
onClick={selectTheme.current[theme.theme_name]}
>
<PersistentElement elt={canvases.current[idx]} />
{canvases.current[idx] && (
<PersistentElement elt={canvases.current[idx]} />
)}
</div>
))}
</div>
Expand Down Expand Up @@ -550,7 +552,9 @@ export function GobanBlackThemePicker(props: GobanThemePickerProperties): JSX.El
}}
onClick={selectTheme.current[theme.theme_name]}
>
<PersistentElement elt={canvases.current[idx]} />
{canvases.current[idx] && (
<PersistentElement elt={canvases.current[idx]} />
)}
</div>
))}
</div>
Expand Down
Loading