Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning-fg color to ogs.styl #2778

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

GreenAsJade
Copy link
Contributor

Fixes warnings being issued about undefined color

Proposed Changes

  • I put the light and dark warning-bg into a "contrasting color generator" online, and created warning-fg with what it gave me

Copy link

github-actions bot commented Aug 13, 2024

Uffizzi Preview deployment-55199 was deleted.

@anoek
Copy link
Member

anoek commented Aug 14, 2024

👍 for fixing the missing variable, not sure how I didn't see that

I've learned over the years though, that you pretty much never want to simply pick the opposite color on the color wheel for text on a background (I've also come to appreciate the difficulty in pairing good colors and creating a good color pallet). For things like this though I've personally started having a lot better luck these days defining the background color in HSL and then adjusting the lightness (L) for contrast for a decent pairing for text, or just going with white/black/some gray. Also the blue looks a lot like a link color:

image

so what I'd do these days is convert that color (#FFAE2C) to HSL: hsl(37, 83, 58.6) and then drop that third component down to make it darker:

hsl(37, 83, 30)

image

hsl(37, 83, 20)
image

hsl(37, 83, 15)
image

hsl(37, 83, 12)
image

Or just go with black

hsl(37, 83, 0)
image

@anoek anoek merged commit 3ee621f into online-go:devel Aug 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants