Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made game log easier to understand (and fixed set-state-before-mounted). #2759

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Made game log easier to understand (and fixed set-state-before-mounted). #2759

merged 1 commit into from
Jul 24, 2024

Conversation

GreenAsJade
Copy link
Contributor

Fixes confusion about what game log is saying

Proposed Changes

  • Get rid of "color" field display in stone_removal_stone_set - not needed, can be confusing (color of what?)
  • Get rid of needs_sealing display
  • Use words that say what the "removed" flag means
  • Don't show stone_removal_stone_set events with no stones (unclear what these are)
  • Dont set log state till we're mounted

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

Uffizzi Preview deployment-54579 was deleted.

@anoek anoek merged commit 614e494 into online-go:devel Jul 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GreenAsJade @anoek