Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include opponent's name in turn notification #2701

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

LForchini
Copy link
Contributor

Fixes #

Proposed Changes

  • Change the format of the notification when it's your move in correspondence games to remove the game id and instead include the username of the opponent.

Motivation

I feel that the game id does not have any use in the notification, whereas I think the opponents name would be more useful.

I am new to this codebase so any advice would be useful, specifically if there's an established method for finding the name of the opponent.

Screenshot from 2024-06-03 09-47-38

Copy link

github-actions bot commented Jun 3, 2024

Uffizzi Preview deployment-52540 was deleted.

@anoek
Copy link
Member

anoek commented Jun 3, 2024

Thanks!

@anoek anoek merged commit b7cdf2d into online-go:devel Jun 3, 2024
4 checks passed
@LForchini LForchini deleted the improve-notification-text branch June 3, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants