-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Copy SGF" Button to Game Dock #2695
Conversation
Uffizzi Ephemeral Environment
|
I'm a little hesitant to merge this as is only because I question whether there is enough demand for this functionality to justify putting it on the already crowded dock. I'm wondering if putting this within the share dialog box or something would be more appropriate? |
I get your concern. Personally, I think the 'Copy SGF' button would prove it fairly useful. Most Go editors support copy-pasting SGF files directly (pressing Ctrl+V inside an editor). This feature would make it super convenient to just quickly copy the SGF and paste it into any editor without cluttering up your drive with downloaded SGF files. As to your suggestion, having to dive into the share dialog after every single game would just add unnecessary clicks, making the whole addition a bit pointless. Another possible approach could be implementing a CTRL+C hotkey on the end game page that copies the SGF content to clipboard. I can work on that if you like the idea. |
This is probably worth some forum discussion on the matter. I'll mark this as draft for now, feel free to open up a thread on the forums and we can proceed based on the discussions had there. |
I also suggested this on a forum a while ago. I would definitely like to use this. |
This pull request has been marked stale and will be closed soon without further activity. Please update the PR or respond to this comment if you're still interested in working on this. |
This pull request has been automatically closed due to inactivity. Please feel free to re-open it if you still want to work on it. |
Proposed Changes
This pull request adds a new "Copy SGF" button to the Game Dock (side panel of the game page), enhancing the user experience by allowing users to copy the SGF content of a game directly to the clipboard. Below are the key changes and features implemented:
New Functionality:
Component Update:
Images: