Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show minimum players to start tournaments #2648

Merged

Conversation

dexonsmith
Copy link
Contributor

Only affects display of tournaments that haven't started.

Maybe would be better to only show the minimum if it hasn't been reached...

@dexonsmith
Copy link
Contributor Author

old:
Image

new:
Image 2

Note the "73/4" on the first tournament. Would it be better to show "73", since the minimum player count of "4" has been reached?

@dexonsmith dexonsmith requested a review from anoek April 1, 2024 16:11
Copy link

github-actions bot commented Apr 1, 2024

Uffizzi Preview deployment-49240 was deleted.

@anoek
Copy link
Member

anoek commented Apr 1, 2024

I think this is an improvement, the only thing giving me pause is it potentially incorrectly conveying that the minimum is actually the maximum number of players in a tournament. I'm not sure that that's that big of a concern or anything, but I thought I'd mention it in case you or anyone else has any thoughts on presentation that might avoid that potential confusion.

@dexonsmith
Copy link
Contributor Author

dexonsmith commented Apr 1, 2024

I think this is an improvement, the only thing giving me pause is it potentially incorrectly conveying that the minimum is actually the maximum number of players in a tournament. I'm not sure that that's that big of a concern or anything, but I thought I'd mention it in case you or anyone else has any thoughts on presentation that might avoid that potential confusion.

I agree the display is ambiguous in that case, but I think it's the minimum that's most relevant for figuring out if the tournament will actually happen. But maybe I'm biased.

One option for showing both would be "count/min-max" when max is different from min. It's a bit awkward because order of operations makes my eyes group the - and / incorrectly though.

Note the "73/4" on the first tournament. Would it be better to show "73", since the minimum player count of "4" has been reached?

Thoughts on this? It would become "73/4-100" in the above case.

@dexonsmith
Copy link
Contributor Author

dexonsmith commented Apr 1, 2024

Note the "73/4" on the first tournament. Would it be better to show "73", since the minimum player count of "4" has been reached?

Thoughts on this? It would become "73/4-100" in the above case.

Another option: .. instead of -. So this would be 73/4..100.

EDIT: The benefit of - is that it's ever used in natural language, whereas .. is a programmer thing.

@dexonsmith
Copy link
Contributor Author

dexonsmith commented Apr 1, 2024

Another option: use an en-dash instead of hyphen -. En-dash is the typographically correct way to do ranges, and maybe doesn't mis-parse as subtraction. Options so far:

  • "73/4"
  • "73" (but "3/4" if not full)
  • "73/4-100"
  • "73/4..100"
  • "73/4–100"

@dexonsmith
Copy link
Contributor Author

(I can ask for input on the forums tonight or tomorrow if you don't have a strong enough opinion... just let me know...)

@anoek
Copy link
Member

anoek commented Apr 1, 2024

Yeah agreed. Let's stick with what you have and leave off the max, if it's actually confusing we can revisit. I do like the idea of omitting the minimum if you're passed it, and maybe that conveys enough information once you're used to it anyways.

So,

2/4 like you have when you're less than the minimum (like you have it)
73 instead of 73/4 when you've exceeded the minimum (like you mentioned in the OP)

@dexonsmith
Copy link
Contributor Author

836f85c:

Image 3

@anoek anoek merged commit a42e050 into online-go:devel Apr 1, 2024
4 checks passed
@dexonsmith dexonsmith deleted the show-minimum-players-to-start-tournaments branch April 1, 2024 16:52
@BHydden
Copy link
Collaborator

BHydden commented Apr 1, 2024

73/4–100

For future reference, if it is needed I like endash best out of the provided options to also show max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants