New User Rank Chooser

[GreenAsJade]

Functionality as per

https://docs.google.com/document/d/1LRjbgZKYfpxSO1mCCdaq-JwXRAOC8mbSh8KWGsk61R0/edit?usp=sharing

• Needs https://github.com/online-go/ogs/pull/1943

[github-actions]

Uffizzi Preview deployment-46801 was deleted.

[anoek]

Let's keep this as draft until the backend is ready for merging, just helps me keep track of things that are ready vs not ready to merge a little easier

[GreenAsJade]

Let's keep this as draft until the backend is ready for merging, just helps me keep track of things that are ready vs not ready to merge a little easier

Yep - just if anyone wants to try this (Uffuzi or for debug) at least it works :)

[dexonsmith]

Yep - just if anyone wants to try this (Uffuzi or for debug) at least it works :)

I just tried using Uffizzi (I've never used it before; seems neat):

1. clicked and waited for load
2. registered new user
3. clicked on profile
4. clicked on play

I never got a prompt with buttons.

Is this expected? (because the backend changes are missing?)

(Hopefully I'll finally get some time this weekend to get back into this so we can finish it off and ship it...)

[GreenAsJade]

Oh yeah, you'll need https://github.com/online-go/ogs/pull/1935 to see anything.

In that PR it's hardwired "on".

(I had meant to mention that in this PR, somehow didn't 🤦‍♀️ )

[GreenAsJade]

Now the back end is there, I've found bunch of places in the front end expecting 1500 as the starting rank, so this PR needs those sorted, I'll get to that next.

---

Hah - turns out most of it was in test code.

The two remaining hassles are:

• The rank graph starts a 1500 glicko on game 0, haven't found where that's coming from yet
• Humble Rank makes it look like the initial setting was "too low"

I wonder if this change does-away with humble rank? Or ... maybe humble rank only for people without starting_rank_hint 🧐

[BHydden]

IIRC, Humble Rank was introduced initially with the intention of allowing brand new users to both play 25k accounts if they are beginners and also to rank up quickly if they are already strong. I don't really see a reason to keep Humble Rank if we are to allow new users to indicate their relative strength before any ranked games are played, especially if the ability to play ranked games beyond a ±9 rank limit is also brought in, as I believe was done recently.

Edit. Rank limit increase is pending backend work #2519

[GreenAsJade]

Yeah - the thing is that users are not forced to choose an initial rank, so there will still be users at the default 1500 rating needing to be able to "play lower than that"

[dexonsmith]

I already have a patch up (draft) that neutralizes humble. Part of the plan as discussed in the forums was to remove it as part of adding starting rank. I still think it makes sense to remove it. On Mar 3, 2024, at 20:10, GreenAsJade ***@***.***> wrote: Yeah - the thing is that users are not forced to choose an initial rank, so there will still be users at the default 1500 rating needing to be able to "play lower than that" —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>

[anoek]

Looking pretty nice man, thanks for doing all of this.

On the profile page, if you've skipped, could we fix the spacing on the left here? Also probably just hide the would-be graph so we don't see the dangling toggle (which I'm realizing probably exists for everyone without rated games which is another minor thing for another day I reckon)

[GreenAsJade]

Fussy fussy! 😅

(Yeah I totally agree... )

[GreenAsJade]

^^ That's done.

[BHydden]

Were those CM changes meant to be pushed to the rank chooser branch?

[GreenAsJade]

Good catch 🤦‍♀️

I'll do some fink.

[anoek]

This is awesome @GreenAsJade , thanks!