Improve styles in chat view (Issue #2375) #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
|
Thanks for the update! |
|
After using this new chat for a while, i gotta admit that i did like the older one more, it had nice old-school IRC feel to it :// Would it be possible to have some option in the settings to choose between the new chat UI and the older one? |
|
I could see the case for an old skool mode. I also dig IRC. However, if we do that I think it'd be better implemented as a site-wide style, not just this one view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2375
Proposed Changes
Improve colors and styling on chat page
Does not yet implement splits for the sidebars, but instead makes them size-responsive (with limits)
Note: this “re-activates” the light theme’s
card-background-color. It used to just lighten#ffffff, which was useless. This darkens it, but only very slightly, so it shouldn’t cause a big upset, but it is now useful.