Change to match goban @type versions

online-go · Oct 1, 2023 · ddce63b · ddce63b
1 parent 4578ab4
commit ddce63b
Show file tree

Hide file tree

Showing 4 changed files with 2,678 additions and 2,417 deletions.
diff --git a/package.json b/package.json
@@ -78,7 +78,8 @@
         "ts-jest": "^29.1.0",
         "ts-loader": "^9.4.2",
         "tslint": "^6.1.3",
-        "typescript": "^5.0.4",
+        "_comment-about-typescript": "vvv current version of eslint-plugin requires this",
+        "typescript": "<5.2.0",
         "webpack": "^5.78.0",
         "webpack-bundle-analyzer": "^4.5.0",
         "webpack-cli": "^4.9.2",
@@ -96,9 +97,9 @@
         "@types/moment-duration-format": "^2.2.2",
         "@types/platform": "^1.3.4",
         "@types/query-string": "^5.0.1",
-        "@types/react": "^18.0.20",
+        "@types/react": "^18.0.28",
         "@types/react-autosuggest": "^10.1.5",
-        "@types/react-dom": "^18.0.6",
+        "@types/react-dom": "^18.0.11",
         "@types/react-virtualized": "^9.21.21",
         "@types/sanitize-html": "^1.22.0",
         "array-move": "^2.2.1",

diff --git a/src/views/LearningHub/LearningHubSection.tsx b/src/views/LearningHub/LearningHubSection.tsx
@@ -16,15 +16,15 @@
  */
 
 import * as React from "react";
-import { LearningPage, DummyPage } from "./LearningPage";
+import { LearningPage, DummyPage, LearningPageProperties } from "./LearningPage";
 import { getFirstUncompletedPage } from "./util";
 
 interface LearningHubSectionProperties {
     page: number;
     title: string;
     nextSection: string;
     section: string;
-    pages: Array<typeof LearningPage>;
+    pages: React.ComponentType<LearningPageProperties>[];
 }
 
 export abstract class LearningHubSection extends React.PureComponent<LearningHubSectionProperties> {
@@ -49,7 +49,7 @@ export abstract class LearningHubSection extends React.PureComponent<LearningHub
         let page = this.props.page || getFirstUncompletedPage(this.props.section);
         page = Math.min(page, this.props.pages.length);
         page = Math.max(page, 0);
-        const P: typeof LearningPage = this.props.pages[page];
+        const P = this.props.pages[page];
         return (
             <P
                 title={this.props.title}

diff --git a/src/views/LearningHub/LearningPage.tsx b/src/views/LearningHub/LearningPage.tsx
@@ -24,7 +24,7 @@ import { browserHistory } from "ogsHistory";
 import { setSectionPageCompleted, getSectionPageCompleted } from "./util";
 import { _ } from "translate";
 
-interface LearningPageProperties {
+export interface LearningPageProperties {
     title: string;
     npages: number;
     curpage: number;