-
Notifications
You must be signed in to change notification settings - Fork 347
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add edge area on iOS icons with white background
- Loading branch information
1 parent
9d41f04
commit b5eacf8
Showing
9 changed files
with
0 additions
and
0 deletions.
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
b5eacf8There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anoek Not to dig these up, but it looks like these merged, but have never deployed. Maybe since they’re static assets they didn’t get bundled properly? Just guessing.
b5eacf8There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://cdn.online-go.com/icons/apple-touch-icon-152x152.png
Spot checks look ok? Where are you seeing issues manifest?
b5eacf8There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears as though the icons currently served up on the CDN have transparent backgrounds and fill the whole width of the square. The images merged into
develare slightly smaller and have white backgrounds. I made these changes because iOS just makes transparency into black, and the icon looks a little funny.It’s easy to miss since Github’s background is white anyway. Not sure what the deploy schedule looks like, so maybe we just haven’t deployed from
develsince that merged? If we have, then the images didn’t appear to update.b5eacf8There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh interesting, ok I'll get those updated. Since those don't change much they aren't part of the normal deployment process.
b5eacf8There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Righto! I guessed maybe the build process skipped copying static binaries around needlessly. 👍🏻
Thanks for updating them!
b5eacf8There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK they are now updated
b5eacf8There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
As of now the icon is still the old one when I try to add it to my home screen. I cleared cache, but I know sometimes the favicons are extra pushy on the caching front. Possible I just missed the one that iOS uses? Trying to suss it out right now.
b5eacf8There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the right image is coming up for me when I visit it directly, though. Wondering which one it actually uses now. 🤔
b5eacf8There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah those images had a TTL of 7 days, so could be they are still cached on the device I imagine
b5eacf8There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah makes sense! I’ll check in a while. 👌🏻