Tweak ChallengeModal for optional close button and Create Game text

online-go · Oct 16, 2024 · 97d00e9 · 97d00e9
1 parent 0fd5c83
commit 97d00e9
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/src/components/ChallengeModal/ChallengeModal.tsx b/src/components/ChallengeModal/ChallengeModal.tsx
@@ -158,7 +158,7 @@ export class ChallengeModal extends Modal<Events, ChallengeModalProperties, any>
 export class ChallengeModalBody extends React.Component<
     ChallengeModalProperties & {
         modal: {
-            close: () => void;
+            close?: () => void;
             on: (event: "open" | "close", callback: () => void) => void;
             off: (event: "open" | "close", callback: () => void) => void;
         };
@@ -170,7 +170,7 @@ export class ChallengeModalBody extends React.Component<
     constructor(
         props: ChallengeModalProperties & {
             modal: {
-                close: () => void;
+                close?: () => void;
                 on: (event: "open" | "close", callback: () => void) => void;
                 off: (event: "open" | "close", callback: () => void) => void;
             };
@@ -320,7 +320,7 @@ export class ChallengeModalBody extends React.Component<
         if (this.props.autoCreate) {
             setTimeout(() => {
                 this.createChallenge();
-                this.props.modal.close();
+                this.props.modal.close?.();
             }, 1);
         }
 
@@ -519,7 +519,7 @@ export class ChallengeModalBody extends React.Component<
 
         console.log("Sending", settings);
         this.saveSettings();
-        this.props.modal.close();
+        this.props.modal.close?.();
 
         if (this.props.game_record_mode) {
             settings.library_collection_id = this.props.libraryCollectionId;
@@ -678,7 +678,7 @@ export class ChallengeModalBody extends React.Component<
         */
 
         this.saveSettings();
-        this.props.modal.close();
+        this.props.modal.close?.();
 
         post(player_id ? `players/${player_id}/challenge` : "challenges", challenge)
             .then((res) => {
@@ -1802,7 +1802,11 @@ export class ChallengeModalBody extends React.Component<
                     </div>
                 )} */}
                 <div className="buttons">
-                    <button onClick={this.props.modal.close}>{_("Close")}</button>
+                    {this.props.modal.close ? (
+                        <button onClick={this.props.modal.close}>{_("Close")}</button>
+                    ) : (
+                        <span />
+                    )}
                     {mode === "demo" && (
                         <button onClick={this.createDemo} className="primary">
                             {this.props.game_record_mode
@@ -1826,7 +1830,7 @@ export class ChallengeModalBody extends React.Component<
                             className="primary"
                             disabled={this.state.input_value_warning}
                         >
-                            {_("Create Challenge")}
+                            {pgettext("Create a game anyone can join", "Create Game")}
                         </button>
                     )}
                 </div>