Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoring overhaul #163

Closed
wants to merge 25 commits into from
Closed

Scoring overhaul #163

wants to merge 25 commits into from

Conversation

anoek
Copy link
Member

@anoek anoek commented Jun 10, 2024 •
edited
Loading

This patch updates the stone removal phase in a number of ways:

  • Switches our scorer to use https://github.com/lightvector/goscorer which does automatic dame detection and proper seki scoring for Japanese rules
  • Adds support for highlighting locations that need sealing before proper scoring can be done
  • Alters the toggling of dead stones in the stone removal phase to make it less error prone
  • Removes the ability to manually flag locations as dame. Moving forward if there is a problem with dame detection, it's considered a bug.
  • Adds a red X to removed stones for clarity

image

  • Adds support for marking scores and dead stones in analysis and reviews

image

image

anoek added 25 commits June 3, 2024 20:06
@anoek
WIP: Add support for needs sealing markings
4c0351a
@anoek
Sealing logic working with our test cases
a3bf2e3
@anoek
Integrate goscorer and update the stone removal phase code
ca2b00c
@anoek
Fixed up tests
fa31fa5
@anoek
Bump various npm deps
114d42d 
Fixes some errors with node 22
@anoek
Bump typescript
26d91da
@anoek
Update score estimator to use goscorer
5d58d4d
@anoek
Remove GoStoneGroup unused code
17d3287
@anoek
Fixed up tests for score estimator using goscorer
3c2503d
@anoek
Make stone removal in score estimation behave like in stone removal
0500e6e 
phase

Also draw the red x's over the stones like the stone removal phase
@anoek
Fixed tests
6b4162a
@anoek
Remove false eyes from score estimates when using territory scoring
768297c
@anoek
Remove old now unused toggleMetaGroupRemoval from GoEngine
efbd5d6
@anoek
Fix tests
41987b9
@anoek
Add support for score marks in analysis and review mode
d51bebc
@anoek
Support marking dead stones in analysis and reviews
0b0a369
@anoek
Refactor: merge GoUtil.ts and Misc.ts -> util.ts
e913023
@anoek
Refactor: add comments
d52116d
@anoek
Refactoring common board and stone removal behavior to common base class
3f0c445 
GoEngine and ScoreEstimator had essentially the same logic.

This also necessitated some refactoring of our "hook" system, now better
named "callbacks" to be less confusing with react hooks.
@anoek
Refactor: GoStoneGroup -> StoneString
5214b49
@anoek
Fix tests
5137008
@anoek
Refactor: Better stone string nomenclature
2c62b64
@anoek
Rename test file
093cd76
@anoek
Refactor: cleanup and comment
68cf82b
@anoek
Refactor: Moving generic board code from GoEngine to Board
ffd2c6d
@anoek anoek closed this Jun 14, 2024
@anoek anoek deleted the scoring branch June 21, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anoek