Goscorer integration and stone removal phase overhaul #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some errors with node 22
phase Also draw the red x's over the stones like the stone removal phase
| }); | ||
| return encodeMoves(moves); | ||
| export function sortMoves(moves: string, width: number, height: number): string; | ||
| export function sortMoves(moves: JGOFMove[], width: number, height: number): JGOFMove[]; |
There was a problem hiding this comment.
It could be nice to allow the caller to omit the width/height arguments in the JGOFMove signature, given that they aren't used.
Suggested change
| export function sortMoves(moves: JGOFMove[], width: number, height: number): JGOFMove[]; | |
| export function sortMoves(moves: JGOFMove[], width?: number, height?: number): JGOFMove[]; |
| public toggleSingleGroupRemoval( | ||
| x: number, | ||
| y: number, | ||
| force_removal: boolean = false, |
There was a problem hiding this comment.
If I'm reading correctly, the only way to trigger this is via shift-click. Is there a mobile-friendly escape hatch as well?
And are we that confident in the algorithm to prevent people from removing groups (without the shift key)
There was a problem hiding this comment.
Long press, I think that trickles down starting from the GobanSVG and GobanCanvas code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the stone removal phase in a number of ways: