Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Set 'handicap' from GoEngine.computeScore to the handicap bonus
This commit changes `GoEngine.computeScore()` to return `0` for `handicap` when it does not contribute to the score. Indirectly, this changes the scoring summary in the web-client to not show the handicap in this case. This fixes an inconsistency in the API/return, which forwarded to the web-client and caused user confusion. Previously it was neither consistently equal to the handicap (see AGA) nor the handicap scoring bonus (see Japanese/Korean/New Zealand). - For Chinese/Ing, it was both the handicap scoring bonus and the handicap, which happen to be equal. - For AGA, it was the handicap scoring bonus, which is `handicap-1`. - For Japanese/Korean/New Zealand, it was the handicap (scoring bonus is 0). Now, for all rulesets, it's the handicap scoring bonus (if any). For a client computing the score, this is what's relevant. This is similar to how `stones` is returned for rulesets where it's relevant to the score. It might be nice for the web-client to show the number of handicap stones somewhere in the main view, but (a) it wasn't doing that previously and (b) `computeScore()` isn't the right way to get that info. Fixes online-go/online-go.com#1469
- Loading branch information