Fix for the start date of the range to allow it to contain a time. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,15 +41,23 @@ const CalendarMonth = React.createClass({ | |||
| let isSelectedRangeStart; | |||
| let isSelectedRangeEnd; | |||
|
|
|||
| if (!hideSelection && value && moment.isMoment(value) && value.isSame(d, 'day')) { | |||
| isSelectedDate = true; | |||
| } else if (!hideSelection && value && isMomentRange(value) && value.contains(d)) { | |||
There was a problem hiding this comment.
The problem was that value.contains would return false when d was say midnight august 2nd and value.start was 5 pm august 2nd. This was only an issue for the start date since the end date of midnight would still be within a date range specified for a time later that same day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to support a date range with a time for the start date, and it wasn't being highlighted properly in the calendar even though it worked fine without a time.