Fix yaml2python convert_import for relative paths and prefixes #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aszs
reviewed
Sep 12, 2023
tests/test_dsl.py
Outdated
| (dict(file="../foo.yaml"), "from ..foo import *"), | ||
| (dict(file="../../foo.yaml"), "from ...foo import *"), | ||
| (dict(repository="unfurl", file="foo.yaml"), "from unfurl.foo import *"), | ||
| (dict(repository="repo", file="foo.yaml", namespace_prefix="tosca.ns", uri_prefix="tosca.ns"), "from repo import foo as tosca.ns"), |
There was a problem hiding this comment.
this should be tosca_repositories.repo see this code in find_repository
return "tosca_repositories." + name, self.repository_paths[name]
i'm surprised the unit test didn't raise an error because of these lines in that function
tpl = self.template.tpl["repositories"][tosca_name or name]
url = normalize_path(tpl["url"])
There was a problem hiding this comment.
ah -- that only happens if the given repo is a URL; i'll add a test case for that. sort of tricky because the template is being mocked here.
There was a problem hiding this comment.
The repo is the name of repository not the url itself... I think the problem is the mock does have a repositories dictionary with the repo as a key
detjensrobert
force-pushed
the
detjensrobert/import-generate-fix
branch
from
7957223 to
d4d04cc
Compare
this makes the type checker happy and enforces TOSCA spec
detjensrobert
force-pushed
the
detjensrobert/import-generate-fix
branch
from
d4d04cc to
b38b530
Compare
also clean up repo link function as a whole Co-Authored-By: Adam Souzis <[email protected]>
detjensrobert
force-pushed
the
detjensrobert/import-generate-fix
branch
from
78aef0b to
833f2ad
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds some initial coverage tests for the changed function.
Draft for now, would appreciate another lookover to see if I missed anything.