Fix umf_ba_free() - do not assert on unknown pointer #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: oneapi-src#903 Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Fix_umf_ba_free_-_do_not_assert_on_unknown_pointer
branch
from
04f4a6d
to
15ec788
Compare
vinser52
reviewed
Nov 18, 2024
| @@ -278,7 +278,11 @@ void umf_ba_free(umf_ba_pool_t *pool, void *ptr) { | |||
| umf_ba_chunk_t *chunk = (umf_ba_chunk_t *)ptr; | |||
|
|
|||
| utils_mutex_lock(&pool->metadata.free_lock); | |||
| assert(pool_contains_pointer(pool, ptr)); | |||
| if (!pool_contains_pointer(pool, ptr)) { | |||
There was a problem hiding this comment.
why should we remove this assert. It was able to catch the issue #903. With this PR we just disable it and issue become silent.
ldorau
deleted the
Fix_umf_ba_free_-_do_not_assert_on_unknown_pointer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
umf_ba_free()- do not assert on unknown pointer.Ref: #903
Checklist