Optimize merge algorithm for data sizes equal or greater then 4M items with SLM cache usage
#1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-implement __find_start_point function Signed-off-by: Sergey Kopienko <[email protected]>
…rename template params in __parallel_merge_submitter Signed-off-by: Sergey Kopienko <[email protected]>
…implementation of __parallel_merge_submitter_large Signed-off-by: Sergey Kopienko <[email protected]>
…using __parallel_merge_submitter_large in the __parallel_merge Signed-off-by: Sergey Kopienko <[email protected]>
…removed redundand comment Signed-off-by: Sergey Kopienko <[email protected]>
…small data types should be acceptable too Signed-off-by: Sergey Kopienko <[email protected]>
…define __base_diagonals_sp_global_ptr outside of parallel_for Signed-off-by: Sergey Kopienko <[email protected]>
…calculate and use cached data-size for work-group Signed-off-by: Sergey Kopienko <[email protected]>
…rename some local variables Signed-off-by: Sergey Kopienko <[email protected]>
…h - debug code Signed-off-by: Sergey Kopienko <[email protected]>
…fix review comment: let's use __parallel_merge_submitter with std::uint32_t data type only Signed-off-by: Sergey Kopienko <[email protected]>
…load source data into SLM by all available work-items in the group Signed-off-by: Sergey Kopienko <[email protected]>
…remove debug code Signed-off-by: Sergey Kopienko <[email protected]>
…rename some variables Signed-off-by: Sergey Kopienko <[email protected]>
…removed redundand comment Signed-off-by: Sergey Kopienko <[email protected]>
…removed redundand assert Signed-off-by: Sergey Kopienko <[email protected]>
…fix unused variable Signed-off-by: Sergey Kopienko <[email protected]>
…rename some variables Signed-off-by: Sergey Kopienko <[email protected]>
…declare load_data_into_slm as inline Signed-off-by: Sergey Kopienko <[email protected]>
…removed redundand assert Signed-off-by: Sergey Kopienko <[email protected]>
…additional comments for load_data_into_slm Signed-off-by: Sergey Kopienko <[email protected]>
…rename some local variables and params Signed-off-by: Sergey Kopienko <[email protected]>
…rewrite the data loading into SLM cache #1 Signed-off-by: Sergey Kopienko <[email protected]>
…h - always use two separate SLM cache Signed-off-by: Sergey Kopienko <[email protected]>
…use large submitter after 16M items Signed-off-by: Sergey Kopienko <[email protected]>
…h - using __parallel_merge_submitter_large for all data sizes Signed-off-by: Sergey Kopienko <[email protected]>
…avoid barrier if we have more then one work-item in each work-group Signed-off-by: Sergey Kopienko <[email protected]>
…avoid any action in the __parallel_merge_submitter_large::operator() if we haven't any data to process Signed-off-by: Sergey Kopienko <[email protected]>
…remove inline on load_data_into_slm_impl Signed-off-by: Sergey Kopienko <[email protected]>
Signed-off-by: Sergey Kopienko <[email protected]>
…rge.h - increate chunk size on GPU to 8" This reverts commit 1b5f0a7.
SergeyKopienko
force-pushed
the
dev/skopienko/optimize_merge_to_main_V21_final
branch
from
9581c3c
to
fde1797
Compare
Signed-off-by: Sergey Kopienko <[email protected]>
Signed-off-by: Sergey Kopienko <[email protected]>
Signed-off-by: Sergey Kopienko <[email protected]>
Signed-off-by: Sergey Kopienko <[email protected]>
Signed-off-by: Sergey Kopienko <[email protected]>
SergeyKopienko
force-pushed
the
dev/skopienko/optimize_merge_to_main_V21_final
branch
from
1487e8d
to
1812dbb
Compare
Signed-off-by: Sergey Kopienko <[email protected]>
SergeyKopienko
force-pushed
the
dev/skopienko/optimize_merge_to_main_V21_final
branch
from
f5e94cd
to
3fdd673
Compare
…fix an error in types of SP on base diagonals Signed-off-by: Sergey Kopienko <[email protected]>
…fix types in __parallel_merge_submitter_large::operator() Signed-off-by: Sergey Kopienko <[email protected]>
…fix types in __serial_merge Signed-off-by: Sergey Kopienko <[email protected]>
…remove extra local variable Signed-off-by: Sergey Kopienko <[email protected]>
SergeyKopienko
force-pushed
the
dev/skopienko/optimize_merge_to_main_V21_final
branch
from
1fbe771
to
253ca8d
Compare
…h - debug code under DUMP_DATA_LOADING Signed-off-by: Sergey Kopienko <[email protected]>
…fix an error in data loading Signed-off-by: Sergey Kopienko <[email protected]>
…fix chunk size on GPU Signed-off-by: Sergey Kopienko <[email protected]>
…fix calculation of available SLM memory amount Signed-off-by: Sergey Kopienko <[email protected]>
…l_merge.h - debug code under DUMP_DATA_LOADING" This reverts commit 952871e.
SergeyKopienko
force-pushed
the
dev/skopienko/optimize_merge_to_main_V21_final
branch
from
f604a72
to
39b68e4
Compare
…another approach to calculate the amount of work-groups and work-items Signed-off-by: Sergey Kopienko <[email protected]>
SergeyKopienko
force-pushed
the
dev/skopienko/optimize_merge_to_main_V21_final
branch
2 times, most recently
from
0aa0ca3
to
56060d0
Compare
…do not use SLM bank size Signed-off-by: Sergey Kopienko <[email protected]>
SergeyKopienko
force-pushed
the
dev/skopienko/optimize_merge_to_main_V21_final
branch
from
56060d0
to
b04b25e
Compare
…use std::size_t instead of _IdType Signed-off-by: Sergey Kopienko <[email protected]>
….h - fix compile errors Signed-off-by: Sergey Kopienko <[email protected]>
…fix compile errors Signed-off-by: Sergey Kopienko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more approach for #1933