[onedpl][ranges] + a fix for "nanoranges" drop_view #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
LGTM. It corresponds to the signature shown in https://en.cppreference.com/w/cpp/ranges/drop_view/end.
Two additional points:
- I will approve it when @timmiesmith allows merging.
- I wonder if we want to sync this file with the original/upstream in the future, and how we keep track of such changes if so. Do you have any strategy?
rarutyun
approved these changes
Sep 12, 2024
dmitriy-sobolev
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[onedpl][ranges] + a fix for "nanoranges" drop_view
The change solves the github issue #1794 and fixes an error in "nanorange" library (drop_view).