Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code change workaround for 64-bit reduce_by_segment bug #1791

Closed
wants to merge 5 commits into from
Closed

Add code change workaround for 64-bit reduce_by_segment bug #1791

wants to merge 5 commits into from

Commits on Aug 20, 2024

  1. Add code change workaround for 64-bit reduce_by_segment bug 

    Filling the SYCL private memory array with the identity prior to loading data works around the encountered IGC bug.
No real performance impact can be measured with this change. The current macro workaround is also removed

Signed-off-by: Matthew Michel <[email protected]>
    @mmichel11
    mmichel11 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    49f4f41 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Add comment explaining workaround 

    Signed-off-by: Matthew Michel <[email protected]>
    @mmichel11
    mmichel11 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    ce29407 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Fill all array elements with __identity instead of just the first 

    Signed-off-by: Matthew Michel <[email protected]>
    @mmichel11
    mmichel11 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    3e08d9d View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Revert "Fill all array elements with __identity instead of just the f… 

    …irst"

I decided to keep this solution as it does not add any additional requirements as I first thought. It looks strange,
as the first element of the array is set to the identity while the others are default constructed. However, this
results in IGC avoiding its own bug internally.

This reverts commit 3e08d9d.
    @mmichel11
    mmichel11 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c6b254c View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Use name of type instead of auto and update comment 

    Signed-off-by: Matthew Michel <[email protected]>
    @mmichel11
    mmichel11 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    558e6b1 View commit details
    Browse the repository at this point in the history