Add requestMessageReconfirm to HomeAMB #605
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality requested under #604 . This PR only makes changes relevant to the AMB contracts. Changes for erc-to-native bridge will be implemented later, in a distinct PR.
For AMB, the requested functionality appeared to be easily integrated to the existing codebase. No oracle modifications are necessary at all. Emitting duplicate
UserRequestForSignature
andCollectedSignatures
events is safe, since oracle does not use transaction hash for constructing the signed message.The flow might be the following:
requestMessageReconfirm
function which re-emitsUserRequestForSignature
and prunes all invalid signatures associated with this message.UserRequestForSignature
event and process it in the usual way. Oracles that have not already submitted their signatures, sign a message and callsubmitSignature
.CollectedSignatures
event.CollectedSignatures
event and executes a message.