Relative daily limit

[maxaleks]

These changes are adding the ability to use a relative daily limit for withdrawals

[patitonar]

Looks good to me! Here are some details that I think we should address before merging this:

• Add unit tests that covers functionality in methods from RelativeDailyLimit contract
• targetLimit and treshold parameter are not initialized in deployment scripts. Should we add them to be also set in initialize methods? @akolotov
• Update flatten script to include new Home/Foreign contracts
• For every new parameter added in .env.example we should add a description in https://github.com/poanetwork/poa-bridge-contracts/blob/master/deploy/README.md

[patitonar]

@maxaleks can you please resolve the merge conflicts?

[maxaleks]

@maxaleks can you please resolve the merge conflicts?

Done

[patitonar]

@maxaleks I updated the new script that verifies the contracts in the explorer as part of the deployment to include the new limit contracts 4aa2b66

[maxaleks]

@patitonar ok, thanks!

[akolotov]

Can you check the merge one more time? For example, I have found that _relayTokens was removed from the ForeignBridgeErcToNative.sol by some reason.
Also I see that the tests were failed for the latest changes in the branch -- could you elaborate the root cause of fails?

[maxaleks]

Can you check the merge one more time? For example, I have found that _relayTokens was removed from the ForeignBridgeErcToNative.sol by some reason.

I removed _relayTokens because it is duplicated in this contract (here and here). Or is this the correct logic?

[maxaleks]

Also I see that the tests were failed for the latest changes in the branch -- could you elaborate the root cause of fails?

Could you rerun the task or, even better, give me rights to do it by myself?

[akolotov]

Can you check the merge one more time? For example, I have found that _relayTokens was removed from the ForeignBridgeErcToNative.sol by some reason.

I removed _relayTokens because it is duplicated in this contract (here and here). Or is this the correct logic?

They are different as far as I see:

95: function _relayTokens(address _sender, address _receiver, uint256 _amount) internal {

vs

183: function _relayTokens(address _sender, address _receiver, uint256 _amount, address _token) internal {

[maxaleks]

They are different as far as I see

Sorry, I missed it when fixing merge conflicts