Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support of simple deployment procedure for several bridge instances #24

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Conversation

akolotov
Copy link
Contributor

proposed changes for #20 and #18

@akolotov akolotov self-assigned this Feb 27, 2018
@akolotov akolotov requested a review from rstormsf February 27, 2018 22:24
@ghost ghost added the in progress label Feb 27, 2018
@rstormsf
Copy link
Contributor

Testing...

@rstormsf
Copy link
Contributor

rstormsf commented Feb 28, 2018

Only 1 side .The only thing I had to do is to call extra methods in order for bridge to work
@phahulin should be aware of this in order to modify his deployment script to call setGas methods

https://kovan.etherscan.io/tx/0x1d963d4968e9cb9b0de626067e1c014fc1a7b9bec13c7ee8a218940de6df586f

Update
after some debugging with @akolotov I got it working
https://kovan.etherscan.io/tx/0xb4154352dcbbca74bc8e37b233a65260249297b40b0a7c29f76347b67c1d32ff

@rstormsf rstormsf merged commit e37ca29 into omni:poa-dev-2 Feb 28, 2018
@ghost ghost removed the in progress label Feb 28, 2018
@phahulin
Copy link
Contributor

phahulin commented Mar 2, 2018

@rstormsf @akolotov thanks for mentioning me.
So I call three setGas... methods after bridge deployment, but for now still keep withdraw_confirm_gas, deposit_relay_gas and withdraw_relay_gas parameters in bridge config, correct? later when some other issues are closed these three parameters will also be removed from bridge config?

@akolotov
Copy link
Contributor Author

akolotov commented Mar 4, 2018

@phahulin, the intention of re-design was to use setGas... by the bridge contract upgrade procecedure in order to change gas usage limits when the bridge contract is deploed initially or changed.
The bridge instance (Rust code) will:

  1. read gasLimitWithdrawRelay, gasLimitDepositRelay and gasLimitWithdrawConfirm as part of initialization procedure and we can get rid of withdraw_confirm_gas, deposit_relay_gas and withdraw_relay_gas from configuration file
  2. watch for event from contracts and as soon as limits are changed, re-initialize internal variables reflecting the limits to use them in new transactions.

noot pushed a commit to noot/poa-bridge that referenced this pull request Jul 18, 2018
Initial support of simple deployment procedure for several bridge instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants