Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter properties for displayValues(); pass options to event #2228

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

jimsafley
Copy link
Member

No description provided.

@zerocrates
Copy link
Member

Looping over all the terms and then looping over the include/exclude arrays within them... I think we'd prefer to avoid that.

For properties I think we could do array_intersect_key($values, array_flip($properties));, and for excludeProperties, array_diff_key($values, array_flip($excludeProperties));

This will avoid looping over the values at all for the usual cases where neither was passed, and should also be more efficient for doing the intersection/difference than the looping version.

@zerocrates zerocrates merged commit eb54866 into develop Sep 12, 2024
5 checks passed
@zerocrates zerocrates deleted the displayvalues-filter-properties branch September 12, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants