refactor: call MenuHandlers without reflection

config/checkstyle/suppressions.xml

@@ -32,6 +32,11 @@
 
     <!-- Permanently suppress errors/warnings -->
 
+    <!-- All menu actions are defined as inner-class in Handler class.
+         MainWindowMenu class imports a hundred of actions with star-import -->
+    <suppress files="MainWindowMenuHandler\.java" checks="FileLength"/>
+    <suppress files="MainWindowMenu\.java" checks="AvoidStarImport"/>
+
     <!-- tests -->
     <suppress files="TestCore\.java" checks="MethodLength"/>
     <suppress checks="(MethodName|MemberName|OperatorWrap)" files=".*Test\.java"/>

src/org/omegat/gui/accesstool/AccessTools.java

@@ -34,7 +34,6 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
-import java.util.Objects;
 import java.util.stream.Collectors;
 
 import javax.swing.Box;
@@ -44,18 +43,16 @@
 import javax.swing.JLabel;
 import javax.swing.JPanel;
 import javax.swing.SwingUtilities;
-import javax.swing.UIManager;
 
 import org.omegat.core.Core;
 import org.omegat.core.CoreEvents;
 import org.omegat.core.events.IProjectEventListener;
-import org.omegat.gui.main.BaseMainWindowMenuHandler;
-import org.omegat.gui.main.MainMenuIcons;
+import org.omegat.gui.main.MainWindowMenuHandler.EditFindInProjectMenuItemAction;
+import org.omegat.gui.main.MainWindowMenuHandler.OptionsPreferencesMenuItemAction;
 import org.omegat.gui.main.ProjectUICommands;
 import org.omegat.util.OConsts;
 import org.omegat.util.OStrings;
 import org.omegat.util.RecentProjects;
-import org.omegat.util.gui.ResourcesUtil;
 
 /**
  * @author Hiroshi Miura
@@ -71,15 +68,13 @@ public class AccessTools extends JPanel {
 
     private ProjectComboBoxModel projectComboBoxModel;
     private SourceComboBoxModel sourceComboBoxModel;
-    private final BaseMainWindowMenuHandler mainWindowMenuHandler;
 
     private URI selectedProject = null;
 
     private static final int MAX_PATH_LENGTH_SHOWN = 25;
     private static final float CHECKBOX_HEIGHT_RATIO = 1.8f;
 
-    public AccessTools(final BaseMainWindowMenuHandler mainWindowMenuHandler) {
-        this.mainWindowMenuHandler = mainWindowMenuHandler;
+    public AccessTools() {
         initComponents();
     }
 
@@ -122,26 +117,19 @@ public void initComponents() {
         sourceFilesCB.setMaximumSize(new Dimension(cbWidth, cbHeight));
         add(sourceFilesCB);
 
-        searchButton = new JButton("",
-                Objects.requireNonNullElseGet(UIManager.getIcon("OmegaT.newUI.search.icon"),
-                        () -> MainMenuIcons.newImageIcon(ResourcesUtil.getBundledImage("newUI.search.png"))));
+        // These buttons show only icon
+        searchButton = new JButton(new EditFindInProjectMenuItemAction());
+        searchButton.setText("");
         searchButton.setBorderPainted(false);
-        settingsButton = new JButton("", Objects.requireNonNullElseGet(
-                UIManager.getIcon("OmegaT.newUI.settings.icon"),
-                () -> MainMenuIcons.newImageIcon(ResourcesUtil.getBundledImage("newUI.settings.png"))));
+        settingsButton = new JButton(new OptionsPreferencesMenuItemAction());
+        settingsButton.setText("");
         settingsButton.setBorderPainted(false);
 
         // -- right side
         add(Box.createGlue());
         add(searchButton);
         add(settingsButton);
 
-        searchButton.addActionListener(actionEvent -> {
-            mainWindowMenuHandler.editFindInProjectMenuItemActionPerformed();
-        });
-        settingsButton.addActionListener(actionEvent -> {
-            mainWindowMenuHandler.optionsPreferencesMenuItemActionPerformed();
-        });
         recentProjectCB.addActionListener(actionEvent -> {
             // when select a project from the list, we open it.
             final Object item = recentProjectCB.getSelectedItem();
@@ -153,13 +141,13 @@ public void initComponents() {
                 if (projectUri.getScheme().equals("omegat")) {
                     switch (projectUri.getSchemeSpecificPart()) {
                     case "new":
-                        mainWindowMenuHandler.projectNewMenuItemActionPerformed();
+                        ProjectUICommands.projectCreate();
                         break;
                     case "open":
-                        mainWindowMenuHandler.projectOpenMenuItemActionPerformed();
+                        ProjectUICommands.projectOpen(null);
                         break;
                     case "team":
-                        mainWindowMenuHandler.projectTeamNewMenuItemActionPerformed();
+                        ProjectUICommands.projectTeamCreate();
                         break;
                     default:
                         break;

src/org/omegat/gui/glossary/GlossaryTextArea.java

@@ -72,6 +72,7 @@
 import org.omegat.gui.editor.EditorUtils;
 import org.omegat.gui.main.DockableScrollPane;
 import org.omegat.gui.main.IMainWindow;
+import org.omegat.gui.main.ProjectUICommands;
 import org.omegat.gui.shortcuts.PropertiesShortcuts;
 import org.omegat.util.HttpConnectionUtils;
 import org.omegat.util.Log;
@@ -414,8 +415,8 @@ public void populatePaneMenu(JPopupMenu menu) {
         openFile.addActionListener(new ActionListener() {
             @Override
             public void actionPerformed(ActionEvent e) {
-                Core.getMainWindow().getMainMenu().invokeAction("projectAccessWritableGlossaryMenuItem",
-                        e.getModifiers());
+                int modifier = e.getModifiers();
+                ProjectUICommands.openWritableGlossaryFile((modifier & ActionEvent.ALT_MASK) != 0);
             }
         });
         openFile.setEnabled(false);