Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: work around for JRE 8 l10n bug #511

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Mar 3, 2023

Pull request type

Please mark github LABEL of the type of change your PR introduces:

  • Bug fix -> [bug]

Which ticket is resolved?

What does this PR change?

Other information

- JRE 8 has a localization bug in Chinese
  - Locale class has wrong display name for
    ZA, SD, SD_IN and SD_PK
- The problem is reported at
  OmegaT-L10N/zh_CN#4
  and
  OmegaT-L10N/zh_CN#5

Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr miurahr added the bug label Mar 3, 2023
@miurahr miurahr requested a review from brandelune March 3, 2023 23:37
@miurahr miurahr added this to the 5.8.0 milestone Mar 3, 2023
@miurahr miurahr added the java8 label Mar 3, 2023
@miurahr
Copy link
Member Author

miurahr commented Mar 4, 2023

You may have an opinion that OmegaT 6.0 will ship with JRE 11 which don't have the bug.

@miurahr miurahr requested a review from kosivantsov March 4, 2023 00:14
@brandelune
Copy link
Contributor

You may have an opinion that OmegaT 6.0 will ship with JRE 11 which don't have the bug.

If the fix is not too hard, let's do it for 5.8.

@miurahr
Copy link
Member Author

miurahr commented Mar 10, 2023

merged into master.

@miurahr miurahr closed this Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants