Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix endpoint #444

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix endpoint #444

merged 1 commit into from
Sep 16, 2024

Conversation

jburel
Copy link
Member

@jburel jburel commented Aug 21, 2024

This PR fixes the URL when submitting to QA. The bug was introduced in #327
The problem was noticed by @pwalczysko when testing the new QA
This prevents the user from submitting a file when an error happens
This might have an impact for the GS QA

@jburel jburel requested a review from sbesson August 21, 2024 12:36
@sbesson
Copy link
Member

sbesson commented Aug 21, 2024

🤦 yes, the endpoint is wrong and should be /qa/upload_processing/ as in

<entry name="/services/DEBUGGER/hostnameProcessing">http://qa.openmicroscopy.org.uk/qa/upload_processing/</entry>
or https://github.com/ome/omero-blitz/blob/bf9a738b0417973de01be3b2f7ccf45ee2eacd19/src/main/java/ome/formats/importer/ImportConfig.java#L561

The problem was noticed by @pwalczysko when testing the new QA

Does this mean the old QA works with the /qa/uploadProcessing/ endpoint and this is why this bug was not flagged as part of the testing of #327?
Or has it always been incorrect and the existing QA deployment can be used for testing both the current (broken) behavior as well as the fix?

@jburel
Copy link
Member Author

jburel commented Aug 21, 2024

It was not noticed during the testing, the entry was recorded and the message was positive but the file was not uploaded.

The new QA does not capture the file probably due to the wrong url

@pwalczysko
Copy link
Member

pwalczysko commented Aug 21, 2024

existing QA deployment can be used for testing both the current (broken) behavior as well as the fix?

Yes, the current QA (OME Team's) deployment will not get files submitted from the most recent release insight 5.8.4. It will get files submitted from insight 5.7.2.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using OMERO.insight by uploading a sample file known to be invalid and broken during the server-side processing
wrong-detector-settings-mk1.ome.xml and sending a feedback using the UI.

Using OMERO.insight 5.8.1 i.e. with the changes from #327 but without this fix, an error message was sent but the file upload failed as described. Note this behavior was the same for a OMERO.server configured with omero.qa.feedback unset in the server configuration i.e. using the default value (QA 41925) as well as a recent OMERO.server configured with omero.qa.feedback explicitly set to http://qa.openmicroscopy.org.uk (QA 41922).

With this PR included the error message and the file were correctly uploaded to the QA app both when omero.qa.feedback was unset in the OMERO configuration (QA 41924) and when omero.qa.feedback was explicitly set (QA 41923).

In conclusion this issue affected the file upload when OMERO.insight was connecting against any recent deployment of OMERO.server independently of whether omero.qa.feedback was set or not. The change fixes the problem in all cases and should probably be released at earliest (possibly with ome/omero-gateway-java#90 which is another regression)

@pwalczysko
Copy link
Member

Confirming the fix. The insight built from this branch with gradle build and gradle run is successfully submitting files. The insight built the same way from master is not.

@jburel jburel merged commit 2ca50c6 into ome:master Sep 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants