-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix endpoint #444
fix endpoint #444
Conversation
🤦 yes, the endpoint is wrong and should be omero-insight/src/config/container.xml Line 180 in efbf7e3
Does this mean the old QA works with the |
It was not noticed during the testing, the entry was recorded and the message was positive but the file was not uploaded. The new QA does not capture the file probably due to the wrong url |
Yes, the current QA (OME Team's) deployment will not get files submitted from the most recent release insight 5.8.4. It will get files submitted from insight 5.7.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested using OMERO.insight by uploading a sample file known to be invalid and broken during the server-side processing
wrong-detector-settings-mk1.ome.xml and sending a feedback using the UI.
Using OMERO.insight 5.8.1 i.e. with the changes from #327 but without this fix, an error message was sent but the file upload failed as described. Note this behavior was the same for a OMERO.server configured with omero.qa.feedback
unset in the server configuration i.e. using the default value (QA 41925) as well as a recent OMERO.server configured with omero.qa.feedback
explicitly set to http://qa.openmicroscopy.org.uk (QA 41922).
With this PR included the error message and the file were correctly uploaded to the QA app both when omero.qa.feedback
was unset in the OMERO configuration (QA 41924) and when omero.qa.feedback
was explicitly set (QA 41923).
In conclusion this issue affected the file upload when OMERO.insight was connecting against any recent deployment of OMERO.server independently of whether omero.qa.feedback
was set or not. The change fixes the problem in all cases and should probably be released at earliest (possibly with ome/omero-gateway-java#90 which is another regression)
Confirming the fix. The insight built from this branch with |
This PR fixes the URL when submitting to QA. The bug was introduced in #327
The problem was noticed by @pwalczysko when testing the new QA
This prevents the user from submitting a file when an error happens
This might have an impact for the GS QA