Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linting and tests #249

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

linting and tests #249

wants to merge 4 commits into from
+1 −1

Conversation

conscioustahoe
Copy link

@conscioustahoe conscioustahoe commented Dec 3, 2018 •
edited
Loading

yarn lint was failing as it was unable to match packages/**/src this pattern

@codecov
Copy link

codecov bot commented Dec 3, 2018 •
edited
Loading

Codecov Report

Merging #249 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files          92       92           
  Lines        1091     1091           
  Branches      165      165           
=======================================
  Hits         1008     1008           
  Misses         68       68           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec531b4...f9c1512. Read the comment docs.

@olistic
Copy link
Owner

olistic commented Dec 3, 2018

Hello @Survivor75, it's not failing for me... Could you tell me what you're seeing and what's your environment?

@conscioustahoe
Copy link
Author

Hey @olistic I am using Windows10

olistic
olistic reviewed Dec 6, 2018
View reviewed changes
package.json Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #249 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files          92       92           
  Lines        1091     1091           
  Branches      165      165           
=======================================
  Hits         1008     1008           
  Misses         68       68           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec531b4...0f86a10. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #249 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files          92       92           
  Lines        1091     1091           
  Branches      165      165           
=======================================
  Hits         1008     1008           
  Misses         68       68           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec531b4...0f86a10. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olistic olistic olistic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conscioustahoe @olistic @codecov-io