Remove clue step items; show deleted + added items

scripts/prepare.ts

@@ -1,5 +1,26 @@
 import minifyDist from './minifyDist';
 import prepareItems from './prepareItems';
+// @ts-ignore asif
+import _items from '../src/data/items/item_data.json';
 
 minifyDist();
-prepareItems();
+const previousItems: string[] = [];
+for (const key of Object.keys(_items)) {
+	previousItems.push(key);
+}
+
+const newItems: string[] = [];
+const deletedItems: string[] = [];
+prepareItems().then(newItemMap => {
+	for (const key of Object.keys(newItemMap))
+	{
+		if (!previousItems.includes(key)) {
+			newItems.push(key);
+		}
+	}
+	for (const key of previousItems) {
+		if (!newItemMap[key]) deletedItems.push(key);
+	}
+	console.log(`Deleted items: ${deletedItems}`);
+	console.log(`New items: ${newItems}`);
+});

scripts/prepareItems.ts

@@ -4,7 +4,7 @@ import { readFileSync, writeFileSync } from 'fs';
 import fetch from 'node-fetch';
 
 import { EquipmentSlot, Item } from '../dist/meta/types';
-import Items, { USELESS_ITEMS } from '../dist/structures/Items';
+import Items, { DO_NOT_REMOVE, USELESS_ITEMS } from '../dist/structures/Items';
 import { itemID } from '../dist/util';
 import { itemChanges } from './manualItemChanges';
 
@@ -30,15 +30,21 @@ interface RawItemCollection {
 	};
 }
 
+// This regex matches the nearly 600 individual clue-step items:
+const clueStepRegex = /^Clue scroll \((beginner|easy|medium|hard|elite|master)\) - .*$/;
+
 function itemShouldntBeAdded(item: any) {
+	if (DO_NOT_REMOVE.includes(item.id)) return false;
+
 	return (
 		USELESS_ITEMS.includes(item.id) ||
 		item.duplicate === true ||
 		item.noted ||
 		item.linked_id_item ||
 		item.placeholder ||
 		item.name === 'Null' ||
-		item.wiki_name?.includes(' (Worn)')
+		item.wiki_name?.includes(' (Worn)') ||
+		(item.wiki_name && clueStepRegex.exec(item.wiki_name))
 	);
 }
 
@@ -228,7 +234,7 @@ const itemsToIgnorePrices = [
 
 const keysToWarnIfRemovedOrAdded: (keyof Item)[] = ['equipable', 'equipment', 'weapon'];
 
-export default async function prepareItems(): Promise<void> {
+export default async function prepareItems() {
 	const messages: string[] = [];
 	const allItemsRaw: RawItemCollection = await fetch(
 		'https://raw.githubusercontent.com/0xNeffarion/osrsreboxed-db/master/docs/items-complete.json'
@@ -426,7 +432,7 @@ export default async function prepareItems(): Promise<void> {
 
 	messages.push(`New Items: ${moidLink(newItems)}.`);
 	messages.push(`Deleted Items: ${moidLink(deletedItems)}.`);
-	const sql = `SELECT 
+	const sql = `SELECT
   ${deletedItems
 		.map(
 			item => `COUNT(*) FILTER (WHERE bank->>'${item.id}' IS NOT NULL) AS people_with_item_${item.id},
@@ -448,4 +454,6 @@ FROM users;
 	writeFileSync('./updates.txt', messages.join('\n'));
 
 	messages.push('Prepared items.');
+
+	return itemNameMap;
 }