Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DT2 Rings Tradeable #6277

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Make DT2 Rings Tradeable #6277

wants to merge 7 commits into from

Conversation

DayV-git
Copy link
Contributor

@DayV-git DayV-git commented Dec 31, 2024

Description:

Here we are again.

Closes #5950.

Changes:

  • Take the actual IDs for the rings, generate the item data, then replace ID with the original ID that's used on the bot
  • Put in safeguard so script cant reuse the beta IDs
  • The prices will be updated as they are already tracked in item_data, and they will have correct stats
  • Repeat logic for a few more items - adds correct price for pharaoh's sceptre
  • On bot side, add in a manual override so the original IDs are used for sprites, so they are updated
  • Changed osjs scripts so prepareItems / enum actually runs on install. The item database we use was updated recently and compatibility fixes will be needed. For now i've just linked to old database commit

Other checks:

  • I have tested all my changes thoroughly.

@DayV-git
Copy link
Contributor Author

DayV-git commented Jan 1, 2025

Unit test is failing on github's end but not mine, suspect github isn't actually rebuilding the monorepo before testing

Edit: prepare scripts aren't run in osjs, unit tests should pass with #6278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DT2 item incorrect data
1 participant