Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amoxliatl #6237

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Amoxliatl #6237

merged 4 commits into from
Nov 27, 2024

Conversation

gc
Copy link
Collaborator

@gc gc commented Nov 27, 2024

Description:

Changes:

Other checks:

  • I have tested all my changes thoroughly.

"members": true,
"combatLevel": 263,
"hitpoints": 520,
"attackType": ["magic"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attackType field should be a string, not an array. Please change "attackType": ["magic"] to "attackType": "magic". This issue is also present in other entries in the file.

Copy link

cloudflare-workers-and-pages bot commented Nov 27, 2024

Deploying oldschoolbot with  Cloudflare Pages  Cloudflare Pages

Latest commit: 22debaa
Status: ✅  Deploy successful!
Preview URL: https://7ce6ad6f.oldschoolbot.pages.dev
Branch Preview URL: https://amoxliatl.oldschoolbot.pages.dev

View logs

.add('Fire rune', [10, 40], 26)
.add('Fire rune', [40, 60], 14)
.add('Chaos rune', [40, 60], 11)
.add('Nature rune', [50, 10], 4)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quantity range for 'Nature rune' seems incorrect. It is currently [50, 10], which should be in ascending order. Please correct it to [10, 50].

Suggested change
.add('Nature rune', [50, 10], 4)
.add('Nature rune', [10, 50], 4)

@gc gc merged commit 49c9f8c into master Nov 27, 2024
4 checks passed
@gc gc deleted the Amoxliatl branch November 27, 2024 03:05
gc added a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant