Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clue trip to be repeated if still have clues in bank #6229

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

DayV-git
Copy link
Contributor

Description:

Concept for repeating clue trips. taskCanBeRepeated checks if you still have a particular tier of clue in bank (or doing implings), and if so lets you carry on, else repeats previous trip. So existing functionality works for non clue trip -> do clue -> repeat button goes back to non-clue trip, but can also spam clue trips. Only downside is there is no indicator/error when you finish clue stack, you just go back to last non-clue trip.

Closes #6227.

Changes:

Add check for clue scrolls in bank for ClueCompletion when checking taskCanBeRepeated for repeating task

Other checks:

  • I have tested all my changes thoroughly.

@gc gc merged commit bb31691 into oldschoolgg:master Nov 26, 2024
4 checks passed
@DayV-git DayV-git deleted the cluefix4 branch November 26, 2024 11:34
@DayV-git DayV-git restored the cluefix4 branch November 28, 2024 09:47
@DayV-git DayV-git deleted the cluefix4 branch November 28, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OSB]
2 participants