Let repeat trips use combat methods, get correct xp for cannoning, prevent cannoning in catacombs #6214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gc
pushed a commit
that referenced
this pull request
Dec 17, 2024
…event cannoning in catacombs (#6214)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Saw that the parsing here removed combat options, so i've just bypassed it and returned the options separately. Perhaps there is a better way but i don't know how the parsing works. Made a handful of changes to make sure repeat trips saves all combat options. Also noticed multi cannoning wasn't giving ranged xp and was using catacombs, so fixed that.
#6169
Changes:
speedCalculationsnow returnscurrentTaskOptionsnon-parsed.multiCannoncheck for getting xp from cannoning.!multiCannoncheck forisInCatacombsOther checks: