Amulet of torture simItems #6202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| @@ -110,7 +110,7 @@ const source: [string, (string | number)[]][] = [ | |||
| ['Tzhaar-ket-om', ['Tzhaar-ket-om (t)']], | |||
| ['Berserker necklace', ['Berserker necklace (or)']], | |||
| ['Amulet of fury', ['Amulet of fury (or)', 'Amulet of blood fury']], | |||
| ['Amulet of torture', ['Amulet of torture (or)']], | |||
| ['Amulet of torture', ['Amulet of torture (or)', 'Amulet of rancour', 'Amulet of rancour (s)']], | |||
There was a problem hiding this comment.
The addition of 'Amulet of rancour' and 'Amulet of rancour (s)' to 'Amulet of torture' similar items is redundant since 'Amulet of rancour' already has 'Amulet of rancour (s)' as a similar item. Consider removing them from this list to avoid duplication.
Suggested change
| ['Amulet of torture', ['Amulet of torture (or)', 'Amulet of rancour', 'Amulet of rancour (s)']], | |
| ['Amulet of torture', ['Amulet of torture (or)']], |
gc
pushed a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add Amulet of rancour and Amulet of rancour(s) to Amulet of torture similar items.
Changes:
similarItems.tsOther checks: