Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ammo and charge messages for /k #6187

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

DayV-git
Copy link
Contributor

@DayV-git DayV-git commented Nov 14, 2024

Description:

Currently, for monster killing trips the message outputs ammo and charge usage that haven't been reduced by ava's / penny.

Updates messages to correct amount reduced. Also removes some of the charge message as it was too much clutter. Includes final message to confirm charges reduced by ghommal penny for monster killing and colo

Changes:

  • Remove old charge use from \k messages, and instead add the message output from removing charge function.
  • Shorted reduce charge message to just the number of charges used per item.
  • Where applicable, add message for reduction from penny
  • Update item costs based on the actual items removed from bank

Other checks:

  • I have tested all my changes thoroughly.

src/lib/colosseum.ts Outdated Show resolved Hide resolved
@gc gc merged commit 81a873c into oldschoolgg:master Nov 21, 2024
4 checks passed
@DayV-git DayV-git deleted the message branch November 21, 2024 20:14
@DayV-git DayV-git restored the message branch November 28, 2024 09:47
@DayV-git DayV-git deleted the message branch November 28, 2024 10:04
gc pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants