BSO - Colosseum Combat Achievement Fix

[TastyPumPum]

Add a fix for the combat achievements One-Off and Denied which is currently only working if you die at wave 11 and 7 respectively or later, rather than colo completions too.

• I have tested all my changes thoroughly.

---

Important

Fixes One-Off combat achievement logic in elite.ts and master.ts to award completion regardless of wave death.

• Behavior:
  • Fixes One-Off combat achievement in elite.ts and master.ts to award completion if player dies before or after wave 11.
• Logic:
  • Updates hasChance function to check if diedAt[index] is undefined or greater than 11 in master.ts and greater than 7 in elite.ts.

^{This description was created by for 1e2ab17. It will automatically update as commits are pushed.}

[TastyPumPum]

@ellipsis-dev review this pr

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 1e2ab17 in 26 seconds

More details

• Looked at 29 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. src/lib/combat_achievements/elite.ts:1525

• Draft comment:
  Avoid using the non-null assertion operator ! as it can lead to runtime errors if the assumption is incorrect. Instead, ensure the value is checked properly.

(!data.diedAt || (Array.isArray(data.diedAt) && (data.diedAt[index] === undefined || data.diedAt[index] > 7)))

• Reason this comment was not posted:
  Confidence changes required: 50%
  The change in the condition is correct, but the use of the non-null assertion operator (!) is unnecessary and can be avoided for better code clarity and safety.

2. src/lib/combat_achievements/master.ts:1476

• Draft comment:
  Avoid using the non-null assertion operator ! as it can lead to runtime errors if the assumption is incorrect. Instead, ensure the value is checked properly.

(!data.diedAt || (Array.isArray(data.diedAt) && (data.diedAt[index] === undefined || data.diedAt[index] > 11)))

• Reason this comment was not posted:
  Confidence changes required: 50%
  The change in the condition is correct, but the use of the non-null assertion operator (!) is unnecessary and can be avoided for better code clarity and safety.

Workflow ID: wflow_1X8bllR5QaQmlFnT

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[nwjgit]

This is something I forgot to fix post multi colo, thanks for doing it. I went ahead and tested it and these are working properly.

Here is my debug/testing:

• Test code:
  
• One-off triggering:
  
• Denied triggering:
  
• Showing has chance being false if user dies before the specified wave: