Wiki gear images #6181
Closed
Wiki gear images #6181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying oldschoolbot with
|
| Latest commit: |
1fc83b6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://040e3546.oldschoolbot.pages.dev |
| Branch Preview URL: | https://wiki-gear-images.oldschoolbot.pages.dev |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| @@ -1,9 +1,10 @@ | |||
| import { readFileSync, writeFileSync } from 'node:fs'; | |||
There was a problem hiding this comment.
Consider using fs.promises.readFile and fs.promises.writeFile for non-blocking I/O operations.
Suggested change
| import { readFileSync, writeFileSync } from 'node:fs'; | |
| import { promises as fs } from 'node:fs'; |
| await writeFile(`./docs/public/images/gear/${imageKey}.png`, image as any); | ||
| console.log(`Generated ${imageKey} gear image`); | ||
| } | ||
| console.log("x"); |
There was a problem hiding this comment.
Remove unnecessary console logs to clean up the code.
Suggested change
| console.log("x"); |
| console.log("z"); | ||
| wtf.dump(); | ||
| process.exit(0); | ||
| wtf.dump(); |
There was a problem hiding this comment.
Remove the redundant wtf.dump() call after process.exit(0) as it will never be executed.
Suggested change
| wtf.dump(); |
| const gear = new Gear(); | ||
| for (const id of itemIDs) gear.equip(getOSItem(id)); | ||
| const image = await generateGearImage( | ||
| { user: { bankBackground: 1 }, farmingContract: () => null } as any, |
There was a problem hiding this comment.
Avoid using any type casting. Use a more specific type or interface for better type safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes:
Other checks: