Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wildy rev weapon boost #6168

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Fix wildy rev weapon boost #6168

merged 2 commits into from
Nov 3, 2024

Conversation

DayV-git
Copy link
Contributor

@DayV-git DayV-git commented Nov 1, 2024

Description:

When new minion kill was implemented the rev weapon boost was incorrectly set to be for revs only, which is always false as the rev boost is handled elsewhere. Fixes this and swaps upgraded and special weapon checks to account for similarItems.

Changes:

  • Removed matchedRevenantMonster check from revWildyGearBoost.
  • Swap upgradedWeapon and specialWeapon so upgraded is handled correctly.

Other checks:

  • I have tested all my changes thoroughly.

@gc gc merged commit 682cb33 into oldschoolgg:master Nov 3, 2024
4 checks passed
@DayV-git DayV-git deleted the revs branch November 17, 2024 11:27
gc pushed a commit that referenced this pull request Dec 17, 2024
@DayV-git @gc
Fix wildy rev weapon boost (#6168)
352c097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DayV-git @gc