Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add corruptedYoungllef creatable #6150

Merged
merged 4 commits into from
Oct 27, 2024
Merged

Conversation

Felris
Copy link
Contributor

@Felris Felris commented Oct 20, 2024

Description:

Adds Corrupted Youngllef as a creatable

Changes:

Added corrupted youngllef as creatable/revertable.
Create checks for 1 corrupted gauntlet KC.

Other checks:

  • I have tested all my changes thoroughly.

@nwjgit
Copy link
Contributor

nwjgit commented Oct 20, 2024

You should put these under their respective sections: metamorphPets and revertMetamorphPets

also minor edit: you could end the fail message with a period and remove the else statement and just leave the if and return null at the very end, similar to other customreqs.

like:

			const [kcName, kcAmount] = await user.getKCByName('Corrupted gauntlet');
			if (kcAmount < 1) {
				return `You need to have at least 1 ${kcName} KC.`;
			}
			return null;
		}

@Felris
Copy link
Contributor Author

Felris commented Oct 20, 2024

You should put these under their respective sections: metamorphPets and revertMetamorphPets

also minor edit: you could end the fail message with a period and remove the else statement and just leave the if and return null at the very end, similar to other customreqs.

like:

			const [kcName, kcAmount] = await user.getKCByName('Corrupted gauntlet');
			if (kcAmount < 1) {
				return `You need to have at least 1 ${kcName} KC.`;
			}
			return null;
		}

Yeah I had done that originally, but I personally prefer explicit else's so I did it my own way. But it's not my code, so you're right, and I updated it to match.

@gc gc merged commit dccac79 into oldschoolgg:master Oct 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants