Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mining effect fix #6118

Merged
merged 10 commits into from
Oct 31, 2024
Merged

mining effect fix #6118

merged 10 commits into from
Oct 31, 2024

Conversation

Lajnux
Copy link
Contributor

@Lajnux Lajnux commented Oct 13, 2024

Description:

fixed so that mining gloves and varrock armour use the updated logics.

Changes:

fixed so that mining gloves and varrock armour use the updated logics.

Other checks:

  • I have tested all my changes thoroughly.

@Lajnux Lajnux requested a review from gc October 13, 2024 20:46
@gc
Copy link
Collaborator

gc commented Oct 16, 2024

I refactored the mining code so it can print out a table of the xp/hr in the wiki, so that I can see if this PR effects those. Running yarn wiki will update this wiki page based on your code, although some merge conflicts will have to be fixed.

image

@Lajnux
Copy link
Contributor Author

Lajnux commented Oct 27, 2024

I refactored the mining code so it can print out a table of the xp/hr in the wiki, so that I can see if this PR effects those. Running yarn wiki will update this wiki page based on your code, although some merge conflicts will have to be fixed.

image

I fixed the merge conflict, not sure if the yarn wiki went good tho, my lint seems slightly different

@gc gc merged commit 96933cd into oldschoolgg:master Oct 31, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants